Repository navigation
Fix @reap_threads usage in test_free_threading.test_json - #158937
Conversation
Use the decorator on test methods, not on the whole class.
Previously, test_json ran no tests:
$ ./python -m test -v test_free_threading.test_json -v
...
Ran 0 tests in 0.000s
NO TESTS RAN
Add also a check in @reap_threads to detect misuse (on a class).
vstinner
added
the
needs backport to 3.15
vstinner
added
tests
|
Hugo already has a PR for this: #158668 |
|
@hugovk @eendebakpt: Would you mind to review this change? Compared to @hugovk's PR gh-158668, my PR moves |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-159115 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
The issue is now nagging me on buildbots, since I added a new check on buildbots to log |
|
GH-159116 is a backport of this pull request to the 3.14 branch. |
|
I also backported the |
…58937) (#159115) Fix @reap_threads usage in test_free_threading.test_json (GH-158937) Use the decorator on test methods, not on the whole class. Previously, test_json ran no tests: $ ./python -m test -v test_free_threading.test_json -v ... Ran 0 tests in 0.000s NO TESTS RAN Add also a check in @reap_threads to detect misuse (on a class). (cherry picked from commit 565f76f) Co-authored-by: Victor Stinner <vstinner@python.org>
2 participants
Use the decorator on test methods, not on the whole class.
Previously, test_json ran no tests:
Add also a check in @reap_threads to detect misuse (on a class).